fix: 🐛 Fix ValueError when using Flag
#2759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Signed-off-by: Paillat <[email protected]>
plun1331
reviewed
May 9, 2025
VincentRPS
previously approved these changes
May 22, 2025
Signed-off-by: Dorukyum <[email protected]>
Dorukyum
requested changes
Jun 4, 2025
Paillat-dev
force-pushed
the
fix/flags-3.11+
branch
from
abcdc95 to
0a6a559
Compare
Paillat-dev
force-pushed
the
fix/flags-3.11+
branch
from
0a6a559 to
1277ff0
Compare
Signed-off-by: Dorukyum <[email protected]>
Dorukyum
approved these changes
Jun 5, 2025
Lulalaby
approved these changes
Jun 5, 2025
VincentRPS
pushed a commit
to Pycord-Development/pycord-next
that referenced
this pull request
Jun 28, 2025
* fix: Role Edit TypeHint (Pycord-Development#2795) Signed-off-by: Lumouille <[email protected]> * fix: command syncing edge cases (Pycord-Development#2797) * change default nsfw to false * cl * localizations * := * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix: VoiceClient crashes while receiving audio (Pycord-Development#2800) Signed-off-by: Hema2 <[email protected]> Co-authored-by: Lala Sabathil <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore(deps): bump typing-extensions from 4.13.1 to 4.13.2 in the patch-version-bumps group (Pycord-Development#2783) chore(deps): bump typing-extensions in the patch-version-bumps group Bumps the patch-version-bumps group with 1 update: [typing-extensions](https://github.com/python/typing_extensions). Updates `typing-extensions` from 4.13.1 to 4.13.2 - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](python/typing_extensions@4.13.1...4.13.2) --- updated-dependencies: - dependency-name: typing-extensions dependency-version: 4.13.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-version-bumps ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: add created_at property to Interaction (Pycord-Development#2801) * feat: add created_at property to Interaction for message creation time * Update CHANGELOG.md * Update discord/interactions.py Co-authored-by: UK <[email protected]> Signed-off-by: Lumouille <[email protected]> * Update CHANGELOG.md Co-authored-by: DA344 <[email protected]> Signed-off-by: Lala Sabathil <[email protected]> --------- Signed-off-by: Lumouille <[email protected]> Signed-off-by: Lala Sabathil <[email protected]> Co-authored-by: UK <[email protected]> Co-authored-by: Lala Sabathil <[email protected]> Co-authored-by: DA344 <[email protected]> * chore(deps): update setuptools requirement from <=78.1.0,>=62.6 to >=62.6,<=80.8.0 (Pycord-Development#2786) chore(deps): update setuptools requirement Updates the requirements on [setuptools](https://github.com/pypa/setuptools) to permit the latest version. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v72.2.0...v80.8.0) --- updated-dependencies: - dependency-name: setuptools dependency-version: 80.8.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore!: 🔥 Remove deprecated support for Option in bridge commands (Pycord-Development#2731) * 🔥 Remove deprecated support for Option in bridge commands * 📝 CHANGELOG.md * ♻️ Better logic --------- Co-authored-by: Dorukyum <[email protected]> * fix: 🐛 `TypeError` when specifying `thread_name` in Webhook.send (Pycord-Development#2761) * 🐛 Handle `thread_name` in `handle_message_parameters` to allow sending to thread with multipart * 📝 CHANGELOG.md * Update CHANGELOG.md Co-authored-by: plun1331 <[email protected]> Signed-off-by: Paillat <[email protected]> --------- Signed-off-by: Paillat <[email protected]> Signed-off-by: Paillat <[email protected]> Co-authored-by: plun1331 <[email protected]> Co-authored-by: Dorukyum <[email protected]> * fix: add BanEntry to __all__ exports in guild.py (Pycord-Development#2798) * fix: add BanEntry to __all__ exports in guild.py * Hold on Signed-off-by: Dorukyum <[email protected]> --------- Signed-off-by: Dorukyum <[email protected]> Co-authored-by: Dorukyum <[email protected]> * fix: correct generic return type in component utils (Pycord-Development#2796) * Update CHANGELOG.md Signed-off-by: Lumouille <[email protected]> * sync with pycord * fix: update Item type hints to Item[View] in view.py * fix: update Item type hints to use TypeVar[V] in view.py --------- Signed-off-by: Lumouille <[email protected]> Co-authored-by: Dorukyum <[email protected]> * chore(deps): update setuptools-scm requirement from <=8.2.1,>=6.2 to >=6.2,<=8.3.1 (Pycord-Development#2785) chore(deps): update setuptools-scm requirement Updates the requirements on [setuptools-scm](https://github.com/pypa/setuptools-scm) to permit the latest version. - [Release notes](https://github.com/pypa/setuptools-scm/releases) - [Changelog](https://github.com/pypa/setuptools-scm/blob/main/CHANGELOG.md) - [Commits](pypa/setuptools-scm@v8.1.0...v8.3.1) --- updated-dependencies: - dependency-name: setuptools-scm dependency-version: 8.3.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update pylint requirement from ~=3.3.6 to ~=3.3.7 (Pycord-Development#2784) Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v3.3.6...v3.3.7) --- updated-dependencies: - dependency-name: pylint dependency-version: 3.3.7 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(pre-commit): pre-commit autoupdate (Pycord-Development#2792) updates: - [github.com/asottile/pyupgrade: v3.19.1 → v3.20.0](asottile/pyupgrade@v3.19.1...v3.20.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * docs: 📝 Fix malformed CHANGELOG.md hyperlinks (Pycord-Development#2804) :memo: Fix CHANGELOG.md formatting * fix: :bug: Fix `ValueError` when using `Flag` (Pycord-Development#2759) * 🐛 Fix `dataclasses.field` can't be reused * 📝 CHANGELOG.md * Update CHANGELOG.md Signed-off-by: Dorukyum <[email protected]> * ♻️ Move `_missing_field_factory` to flags.py and remove incorrect comment --------- Signed-off-by: Paillat <[email protected]> Signed-off-by: Dorukyum <[email protected]> Co-authored-by: Dorukyum <[email protected]> * ci(deps): bump crowdin/github-action from 2.7.0 to 2.7.1 in the patch-version-bumps group (Pycord-Development#2805) ci(deps): bump crowdin/github-action in the patch-version-bumps group Bumps the patch-version-bumps group with 1 update: [crowdin/github-action](https://github.com/crowdin/github-action). Updates `crowdin/github-action` from 2.7.0 to 2.7.1 - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@v2.7.0...v2.7.1) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-version: 2.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-version-bumps ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: resolve regex library warnings (Pycord-Development#2807) Signed-off-by: Emmanuel Ferdman <[email protected]> * fix: support emoji aliases like `:smile:` in PartialEmoji.from_str (Pycord-Development#2774) * handle emoji_lib Signed-off-by: Lumouille <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md Signed-off-by: Lumouille <[email protected]> * usage of dismoji Signed-off-by: Lumouille <[email protected]> * Update _.txt Signed-off-by: Lumouille <[email protected]> * removal of dismoji Signed-off-by: Lumouille <[email protected]> * Update _.txt Signed-off-by: Lumouille <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks * NEED HELP Signed-off-by: Lumouille <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks * Update partial_emoji.py Signed-off-by: Lumouille <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks * Add files via upload Signed-off-by: Lumouille <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks * Update partial_emoji.py Signed-off-by: Lumouille <[email protected]> * Update discord/partial_emoji.py Co-authored-by: plun1331 <[email protected]> Signed-off-by: Lumouille <[email protected]> * feature(partial_emoji): support :name: and name * fix(partial_emoji): remove unnecessary data variable after processing emojis * Update partial_emoji.py Co-authored-by: Paillat <[email protected]> Signed-off-by: Lumouille <[email protected]> * reduce emoji.json weight * Update emojis.json Signed-off-by: Lumouille <[email protected]> * refactor: replace Path with importlib.resources for loading emojis.json * Update emojis.json Signed-off-by: Lumouille <[email protected]> --------- Signed-off-by: Lumouille <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: plun1331 <[email protected]> Co-authored-by: Paillat <[email protected]> Co-authored-by: Lala Sabathil <[email protected]> * Revert "fix: support emoji aliases like `😄` in PartialEmoji.from_str" (Pycord-Development#2814) Revert "fix: support emoji aliases like `:smile:` in PartialEmoji.from_str (#…" This reverts commit 735673b. * Apply suggestions from code review Signed-off-by: Paillat <[email protected]> * Update discord/utils.py Signed-off-by: Paillat <[email protected]> * Update discord/utils.py Signed-off-by: Paillat <[email protected]> * Update discord/ext/commands/flags.py Signed-off-by: Paillat <[email protected]> * 🚨 Fix linter warnings --------- Signed-off-by: Lumouille <[email protected]> Signed-off-by: Hema2 <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Lala Sabathil <[email protected]> Signed-off-by: Paillat <[email protected]> Signed-off-by: Paillat <[email protected]> Signed-off-by: Dorukyum <[email protected]> Signed-off-by: Emmanuel Ferdman <[email protected]> Co-authored-by: Lumouille <[email protected]> Co-authored-by: UK <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Hema2 <[email protected]> Co-authored-by: Lala Sabathil <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lala Sabathil <[email protected]> Co-authored-by: DA344 <[email protected]> Co-authored-by: Dorukyum <[email protected]> Co-authored-by: plun1331 <[email protected]> Co-authored-by: Emmanuel Ferdman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See also my comment on #2443 .
The issue was that a
dataclasses.fieldobject could not be reused and caused unhelpfulTypeErrors.This, or something fixing this issue should ideally be merged before #2443 is merged, and then master merged into #2443 .
Information
fixes:
TypeErrorwhen usingFlagwith python 3.11+ #2758examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.